WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] hvm: remove pt_reset()

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] hvm: remove pt_reset()
From: Kouya Shimura <kouya@xxxxxxxxxxxxxx>
Date: Tue, 1 Sep 2009 16:46:00 +0900
Delivery-date: Tue, 01 Sep 2009 00:46:33 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Virtual platform timers are not sync'ed with guest's TSC any more
since c/s 17716. Thus pt_reset is now useless.

Signed-off-by: Kouya Shimura <kouya@xxxxxxxxxxxxxx>

diff -r b4fcb5f632dc xen/arch/x86/hvm/hvm.c
--- a/xen/arch/x86/hvm/hvm.c    Mon Aug 31 18:17:26 2009 +0100
+++ b/xen/arch/x86/hvm/hvm.c    Tue Sep 01 16:13:14 2009 +0900
@@ -1890,7 +1890,6 @@ int hvm_msr_write_intercept(struct cpu_u
     {
      case MSR_IA32_TSC:
         hvm_set_guest_tsc(v, msr_content);
-        pt_reset(v);
         break;
 
     case MSR_IA32_APICBASE:
diff -r b4fcb5f632dc xen/arch/x86/hvm/vpt.c
--- a/xen/arch/x86/hvm/vpt.c    Mon Aug 31 18:17:26 2009 +0100
+++ b/xen/arch/x86/hvm/vpt.c    Tue Sep 01 16:13:14 2009 +0900
@@ -327,24 +327,6 @@ void pt_intr_post(struct vcpu *v, struct
         cb(v, cb_priv);
 }
 
-void pt_reset(struct vcpu *v)
-{
-    struct list_head *head = &v->arch.hvm_vcpu.tm_list;
-    struct periodic_time *pt;
-
-    spin_lock(&v->arch.hvm_vcpu.tm_lock);
-
-    list_for_each_entry ( pt, head, list )
-    {
-        pt->pending_intr_nr = 0;
-        pt->last_plt_gtime = hvm_get_guest_time(pt->vcpu);
-        pt->scheduled = NOW() + pt->period;
-        set_timer(&pt->timer, pt->scheduled);
-    }
-
-    spin_unlock(&v->arch.hvm_vcpu.tm_lock);
-}
-
 void pt_migrate(struct vcpu *v)
 {
     struct list_head *head = &v->arch.hvm_vcpu.tm_list;
diff -r b4fcb5f632dc xen/include/asm-x86/hvm/vpt.h
--- a/xen/include/asm-x86/hvm/vpt.h     Mon Aug 31 18:17:26 2009 +0100
+++ b/xen/include/asm-x86/hvm/vpt.h     Tue Sep 01 16:13:14 2009 +0900
@@ -138,7 +138,6 @@ void pt_restore_timer(struct vcpu *v);
 void pt_restore_timer(struct vcpu *v);
 void pt_update_irq(struct vcpu *v);
 void pt_intr_post(struct vcpu *v, struct hvm_intack intack);
-void pt_reset(struct vcpu *v);
 void pt_migrate(struct vcpu *v);
 
 void pt_adjust_global_vcpu_target(struct vcpu *v);
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] hvm: remove pt_reset(), Kouya Shimura <=