WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] XEN: remove undefined functions

To: Jaswinder Singh Rajput <jaswinder@xxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] XEN: remove undefined functions
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Tue, 25 Aug 2009 09:32:10 -0700
Cc: Chris Wright <chrisw@xxxxxxxxxxxx>, virtualization@xxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, Jeremy Fitzhardinge <jeremy@xxxxxxxxxxxxx>
Delivery-date: Tue, 25 Aug 2009 09:32:37 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1251194494.2399.22.camel@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1251194494.2399.22.camel@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.1) Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Lightning/1.0pre Thunderbird/3.0b3
On 08/25/09 03:01, Jaswinder Singh Rajput wrote:
> mk_pirq_info(), gsi_from_irq() and vector_from_irq() are static functions
> and no one is calling them.
>
> This fixed following compilation warnings :
>
>   drivers/xen/events.c:134: warning: ‘mk_pirq_info’ defined but not used
>   drivers/xen/events.c:180: warning: ‘gsi_from_irq’ defined but not used
>   drivers/xen/events.c:190: warning: ‘vector_from_irq’ defined but not used
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@xxxxxxxxx>
>   

Hm, they're all about to become used.

    J
> ---
>  drivers/xen/events.c |   27 ---------------------------
>  1 files changed, 0 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/xen/events.c b/drivers/xen/events.c
> index abad71b..d43957a 100644
> --- a/drivers/xen/events.c
> +++ b/drivers/xen/events.c
> @@ -131,13 +131,6 @@ static struct irq_info mk_virq_info(unsigned short 
> evtchn, unsigned short virq)
>                       .cpu = 0, .u.virq = virq };
>  }
>  
> -static struct irq_info mk_pirq_info(unsigned short evtchn,
> -                                 unsigned short gsi, unsigned short vector)
> -{
> -     return (struct irq_info) { .type = IRQT_PIRQ, .evtchn = evtchn,
> -                     .cpu = 0, .u.pirq = { .gsi = gsi, .vector = vector } };
> -}
> -
>  /*
>   * Accessors for packed IRQ information.
>   */
> @@ -177,26 +170,6 @@ static unsigned virq_from_irq(unsigned irq)
>       return info->u.virq;
>  }
>  
> -static unsigned gsi_from_irq(unsigned irq)
> -{
> -     struct irq_info *info = info_for_irq(irq);
> -
> -     BUG_ON(info == NULL);
> -     BUG_ON(info->type != IRQT_PIRQ);
> -
> -     return info->u.pirq.gsi;
> -}
> -
> -static unsigned vector_from_irq(unsigned irq)
> -{
> -     struct irq_info *info = info_for_irq(irq);
> -
> -     BUG_ON(info == NULL);
> -     BUG_ON(info->type != IRQT_PIRQ);
> -
> -     return info->u.pirq.vector;
> -}
> -
>  static enum xen_irq_type type_from_irq(unsigned irq)
>  {
>       return info_for_irq(irq)->type;
>   


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>