WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH]: Implement bzip2 and LZMA loaders / fixed patch

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH]: Implement bzip2 and LZMA loaders / fixed patch for Xen 3.4.1
From: Pasi Kärkkäinen <pasik@xxxxxx>
Date: Fri, 21 Aug 2009 12:44:25 +0300
Cc: Chris Lalancette <clalance@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 21 Aug 2009 02:46:33 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20090821092243.GL19938@xxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C6B37B80.129A5%keir.fraser@xxxxxxxxxxxxx> <C6B37E51.129A8%keir.fraser@xxxxxxxxxxxxx> <20090821092243.GL19938@xxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.13 (2006-08-11)
On Fri, Aug 21, 2009 at 12:22:43PM +0300, Pasi Kärkkäinen wrote:
> On Thu, Aug 20, 2009 at 10:27:29PM +0100, Keir Fraser wrote:
> > On 20/08/2009 22:15, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote:
> > 
> > >> Hmm, actually this patch seems to break stubdom build/linking:
> > > 
> > > I checked in a variant as c/s 20103, which at least for non-stubdom build 
> > > of
> > > libxenguest should do the right thing if liblzma-devel or libbz2-devel
> > > packages (or whatever they are called) are not installed. See how that 
> > > goes
> > > with stubdom. We may just have to massage the Makefile a little more to 
> > > kill
> > > off the bz2/lzma stuff for stubdom. I'm not sure why libxenguest is 
> > > getting
> > > built for stubdom in the first place though. It's not likely to be very
> > > useful!
> > 
> > Okay, I tested and fixed the stubdom case, so hopefully c/s 20104 will
> > actually work for you.
> > 
> 
> xen-unstable "make tools && make stubdom" compiles for me with and without
> libbz2-devel/liblzma-devel installed.
> 
> But even when I have liblzma-devel installed it doesn't seem to use it. 
> ie. I only see -DHAVE_BZLIB in the build log and libxenguest.so.3.4.0 gets
> only linked against -lbz2.
> 
> Investigating more..
> 

Ok, that was a stupid problem. I tried to build on Ubuntu box now (instead
of Fedora), and it seems lzma-dev was not the correct/needed package, 
but I had to install liblzma-dev.

So it seems to build OK for me. I'll verify also on Fedora later today.

-- Pasi

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>