WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Include in balloon page tracking only PFNs which

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH] Include in balloon page tracking only PFNs which are marked as RAM in E820.
From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Date: Wed, 19 Aug 2009 15:16:07 -0400
Cc: gianluca.guida@xxxxxxxxxx, Konrad Rzeszutek Wilk <kliw@xxxxxxxxxx>
Delivery-date: Wed, 19 Aug 2009 12:21:36 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1250709149-4730-2-git-send-email-konrad.wilk@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1250709149-4730-1-git-send-email-konrad.wilk@xxxxxxxxxx> <1250709149-4730-2-git-send-email-konrad.wilk@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.19 (2009-01-05)
Gianluca,

I had not done any extensive testing. Would appreciate your feedback on this 
patch.

On Wed, Aug 19, 2009 at 03:12:29PM -0400, Konrad Rzeszutek Wilk wrote:
> From: Konrad Rzeszutek Wilk <kliw@xxxxxxxxxx>
> 
> Signed-off-by: Konrad Rzeszutek Wilk <kliw@xxxxxxxxxx>
> ---
>  drivers/xen/balloon.c |    8 ++++++--
>  1 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
> index 168e61f..ef2edd8 100644
> --- a/drivers/xen/balloon.c
> +++ b/drivers/xen/balloon.c
> @@ -416,8 +416,12 @@ static int __init balloon_init(void)
>  
>       /* Initialise the balloon with excess memory space. */
>       for (pfn = xen_start_info->nr_pages; pfn < max_pfn; pfn++) {
> -             page = pfn_to_page(pfn);
> -             balloon_append(page);
> +             int is_ram = page_is_ram(pfn);
> +             if (is_ram) {
> +                     page = pfn_to_page(pfn);
> +                     if (PageReserved(page))
> +                             balloon_append(page);
> +             }
>       }
>  
>       target_watch.callback = watch_target;
> -- 
> 1.6.2.5
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel