WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Add script to compile different versions of pyth

To: Andreas Florath <xen@xxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Add script to compile different versions of python; add python syntax checker
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 29 Jul 2009 08:40:35 +0100
Cc:
Delivery-date: Wed, 29 Jul 2009 00:41:22 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4A6FD2C1.60906@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcoQBszmDr0Lcn3VSM6zP4vfD7j8cQAGQ7XB
Thread-topic: [Xen-devel] [PATCH] Add script to compile different versions of python; add python syntax checker
User-agent: Microsoft-Entourage/12.20.0.090605
On 29/07/2009 05:40, "Andreas Florath" <xen@xxxxxxxxxxxx> wrote:

> just recognised that the patch was applied - but the directory is now
> different from the original.  This breaks the Makefile and the provided
> scripts.
> 
> I'll send a patch against the current tip this evening.

Ah, I just assumed it would all be relative to the directory it's resident
in. Of course XEN_ROOT does need fixing (I forgot about that), but then you
can make yourself a local-dir variable based directly on $(PWD) rather than
$(XEN_ROOT).

Also, at the same time it would be good if you would replace ${} make
variable expansions with $(). It's purely a style consistency thing, as we
use the latter in all other Makefiles.

 Thanks,
 Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel