[Xen-devel] Re: compat tool problem with new tmem save/restore tmem_op struct

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

>>> Dan Magenheimer <dan.magenheimer@xxxxxxxxxx> 28.07.09 20:00 >>>
>I'm trying to implement save/restore code for tmem
>and to do so I need to pass other variants of the
>tmem_op struct between tools (dom0) and the hypervisor
>so I made the changes below to struct tmem_op.
>Unfortunately the nested union seems to break your compat
>translation tool.  Is this an easy fix for your
>tool?  If not, I suppose I can recode to only
>use a single level of union.

Would be good if you pointed out *how* it fails - it doesn't look as if it
should have a problem with such a layout (and hence if it does I'd think
it should be fixed). I'll try it out myself once I can get to it, but it's 
unlikely
that this would be earlier than next week.

And (after having read you follow up mail) I'd think flattening the structure
isn't the right thing to do.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel