 Home |
Products |
Support |
Community |
News |
xen-devel
[Xen-devel] Re: [PATCH][ioemu] Ignore the first watch fire in xenstore_p
| To: | "Cui, Dexuan" <dexuan.cui@xxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | [Xen-devel] Re: [PATCH][ioemu] Ignore the first watch fire in xenstore_process_dm_command_event() |
| From: | Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
| Date: | Tue, 16 Jun 2009 18:27:02 +0100 |
| Cc: | Simon Horman <horms@xxxxxxxxxxxx> |
| Delivery-date: | Tue, 16 Jun 2009 10:27:35 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <EADF0A36011179459010BDF5142A457501C9D98D00@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcnupHMbtaiyBz5ES9eQlob+b3qwNgAAzXzR |
| Thread-topic: | [PATCH][ioemu] Ignore the first watch fire in xenstore_process_dm_command_event() |
| User-agent: | Microsoft-Entourage/12.19.0.090515 |
On 16/06/2009 18:04, "Cui, Dexuan" <dexuan.cui@xxxxxxxxx> wrote: > A straightforward thought is: we can ignore the first watch fire. Please see > the below patch. > However I'm not sure if this is the best fix. And for the other watches(like > "logdirty", "hdc") set in xenstore_parse_domain_config(), I think we should > also double check them even if no actual bug has been observed yet. > > Please comment. Can you not treat the watch firing as an indication of maybe-changed, and decide what to do based on current values you read from xenstore from within the watch handler? -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] Re: [PATCH][ioemu] Ignore the first watch fire in xenstore_process_dm_command_event(), Ian Jackson |
|---|---|
| Next by Date: | [Xen-devel] RE: [PATCH][ioemu] Ignore the first watch fire in xenstore_process_dm_command_event(), Cui, Dexuan |
| Previous by Thread: | [Xen-devel] RE: [PATCH][ioemu] in xenstore_process_dm_command_event(), xs_rm the command node after we read it., Cui, Dexuan |
| Next by Thread: | [Xen-devel] [PATCH] [linux-2.6.18-xen] (take 3) transcendent memory ("tmem") linux-side changes, Dan Magenheimer |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
