WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] update stubdom config example

To: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] update stubdom config example
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Tue, 16 Jun 2009 17:09:24 +0100
Cc:
Delivery-date: Tue, 16 Jun 2009 09:06:23 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20090616155652.GT5866@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4A37BE49.4070400@xxxxxxxxxxxxx> <20090616155652.GT5866@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.14 (X11/20080505)
Samuel Thibault wrote:

> Stefano Stabellini, le Tue 16 Jun 2009 16:46:17 +0100, a écrit :
>> this patch updates the stubdom config example to reflect that the serial
>> option can now be used.
> 
> Ok, so now I see what your previous patch is for :) I still think
> openpty() shouldn't be used, as a standard function with the same name
> but different prototype exists, that would lead us to troubles. I would
> rather see it as open("/dev/ptmx") and/or posix_openpt(), which actually
> does the same, but can be interfaced in a standard way. And then we
> could even implement pts_name() to provide the console frontend path.
> 

I wasn't aware of posix_openpt, I think that is the best choice.
I'll resend the patch and also update the qemu patch that uses it.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>