Re: tmem 32-on-64 needs (Re: [Xen-devel] [PATCH] tmem cleanup)

>>> John Levon <levon@xxxxxxxxxxxxxxxxx> 15.06.09 20:54 >>>
>On Mon, Jun 15, 2009 at 03:09:26PM +0100, Jan Beulich wrote:
>
>> sending a patch out for: xen/include/public/tmem.h uses anonymous unions
>> and structures - all other public headers (with the exception of the 
>> declaration
>> of xenpf_set_processor_pminfo and xen_sysctl_pm_op, which probably are
>> mistakes/oversights)
>
>FYI both the pminfo code and anything else that uses anon struct/unions in
>public headers is a constant pain for us. Sun Studio compilers can sort
>of do it, but it's too buggy to use right now.

I'll have to see whether gcc has a mode to make it reject anything non-
standard - if so, I'd like to add to the build a header validation step that
ensures no extensions are used outside of __GNUC__, __XEN__, or __XEN_TOOLS__
conditionals.

In any case, I added fixing the public headers to my to-do list.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:

RE: tmem 32-on-64 needs (Re: [Xen-devel] [PATCH] tmem cleanup), Jan Beulich

Next by Date:

Re: [Xen-devel] Sched planning: Ideal scheduler, and credit1, XiaYubin

Previous by Thread:

Re: tmem 32-on-64 needs (Re: [Xen-devel] [PATCH] tmem cleanup), John Levon

Next by Thread:

[Xen-devel] Baffled by multipage_allocation_permitted(), Dave McCracken

Indexes:

[Date] [Thread] [Top] [All Lists]