WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: Dom0 crashing when built with c/s 881 (Was: [Xen-devel] blktap2: ne

To: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>, Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Subject: Re: Dom0 crashing when built with c/s 881 (Was: [Xen-devel] blktap2: need more than 3 values to unpack)
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 03 Jun 2009 22:27:33 +0100
Cc: "Xen-Devel \(E-mail\)" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 03 Jun 2009 14:27:58 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <c54eb33a-47cc-494e-a5ab-2d0bdb825b41@default>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcnkkKyY6M0Fn+I1TESvqr8/mElMNAAAW6i/
Thread-topic: Dom0 crashing when built with c/s 881 (Was: [Xen-devel] blktap2: need more than 3 values to unpack)
User-agent: Microsoft-Entourage/12.17.0.090302
On 03/06/2009 22:17, "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx> wrote:

>>  1. It only adds extra functionality which by default would
>> not do anything.
>> Just reading the patch I can see it's harmless by itself as it merely
>> introduces a new notifier chain which noone registers on.
> 
> I won't pretend to understand the code, but I did
> reproduce the problem with 881 by itself and with
> 889 with 881 reverted.

I can't explain that from reading the code. It looks like a no-op to me
unless the new function bus_register_notifier() is called.

>>  2. Changeset 882 depends on 881. If you revert just 881 then
>> the tree will not build.
> 
> This doesn't appear to be the case for me, though
> I'm certainly willing to believe there's something
> wrong with my process:

Actually I missed that the dependent code is only built if
CONFIG_PCI_IOMULTI && CONFIG_HOTPLUG_PCI. You've probably got one or both
disabled and hence 882 doesn't break without 881 in your case.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>