WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Question about the dynamic sizing of the PCI hole

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] Question about the dynamic sizing of the PCI hole
From: Tom Rotenberg <tom.rotenberg@xxxxxxxxx>
Date: Mon, 25 May 2009 12:01:15 +0300
Delivery-date: Mon, 25 May 2009 02:01:45 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type; bh=laENv2kqGA90JHtcbGOkksia7FnjDpsq8dhWG1ih+qM=; b=ifLvvSnl6rlOm6cyVJDzTmDEUzsPFJmmtaQ7l4Stb3SktCQRHsX+uezFJnivV4BOC9 J8kqGbq1mDRaS6PegVHCoh5AaEMsAx7a5U9f8qSBh2YUoxYUa9qp7nEOrwwtYPOlIn/d yXzesqaJ/d2L61brK3BpsQGn37hBedvYWoBao=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=weaLuZSpo6wLG+/E2xEV7TzKlIke2ecFUq0LGJhchcnZ68gqpzWrwMeVx/CAIYitgX yJQOxI7fld4kU5P9JtRkOT7EbG7jetqqsKQ4PVAyZkPTjPPirXWclN5ixKkMbBocvrDG /oEr9k8Hc8MpOY+tt8+JXlyjFZ7JYZbDZ6wtc=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi,

I am reviewing the code of the hvmloader from Xen 3.4, and i saw that in changeset 19021, there was a patch which added the ability to dynamically size the PCI hole. I have seen that this patch calculates the total memory size, but i failed to understand the following lines:

while ( (mmio_total > (pci_mem_end - pci_mem_start)) &&
            ((pci_mem_start << 1) != 0) )
        pci_mem_start <<= 1;

It looks as if the pci mem start will be increased if there isn't enough space for the PCI devices, although, as far as i understand, it should be decreased (so the PCI hole will be enlarged). So, shouldn't it be: "pci_mem_start >> = 1" ?

Thanks,
       Tom
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel