| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
[Xen-devel] Re: [Qemu-devel] [PATCH 02/10] xen: backend driver core
Gerd Hoffmann wrote:
On 04/07/09 21:41, Anthony Liguori wrote:
+/* private */
+static TAILQ_HEAD(XenDeviceHead, XenDevice) xendevs =
TAILQ_HEAD_INITIALIZER(xendevs);
+static int debug = 0;
Would be better to have all of this in a structure that had a single
static instance. Would be even better if you could avoid requiring the
static instance.
Huh? Point being? This is just a list head, i.e. a pointer (or two?).
I meant the public stuff too. I don't like having extern variables all
over the place.
It would be better to have this in a structure that was passed to all of
the backend drivers that they then passed as a context. This will
become more useful down the road too when we start introducing a common
device model and finer grain locking.
Regards,
Anthony Liguori
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home