WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] Fixes for build/install system

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] Fixes for build/install system
From: Christoph Egger <Christoph.Egger@xxxxxxx>
Date: Wed, 1 Apr 2009 08:44:39 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>
Delivery-date: Wed, 01 Apr 2009 00:45:18 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <18898.16577.474687.221544@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <200903311422.14692.Christoph.Egger@xxxxxxx> <18898.16577.474687.221544@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.7
On Tuesday 31 March 2009 18:11:45 Ian Jackson wrote:
> Christoph Egger writes ("[PATCH] Fixes for build/install system"):
> > Attached patches get rid of hardcoded install path,
> > fixes wrong install paths and replaces mkdir -p with $(INSTALL_DIR).
> > All in all, a command like PREFIX="/usr/local" gmake dist
> > now installs everything into dist/install/usr/local
> > instead of dist/install/usr
>
> This is all very nice but
>
> >  install-doc: $(DOCS)
> > -   mkdir -p "$(DESTDIR)$(docdir)"
> > +   $(INSTALL_DIR) "$(DESTDIR)$(docdir)"
> >     $(INSTALL) -m 644 qemu-doc.html  qemu-tech.html "$(DESTDIR)$(docdir)"
>
> these are parts of the Makefile which come from upstream qemu.
> I definitely don't want to modify those parts.  Everything which is
> done in the makefiles in qemu-xen-unstable is aimed at avoiding large
> textual changes which make merging difficult.  We don't want changes
> in our versions of the upstream makefiles which are not absolutely
> necessary to make things work.
>
> It's not clear to me by inspection whether I can safely apply the
> other parts of your qemu patch on their own.  Can you confirm ?

Yes, I can confirm. It is just less consistent throughout the whole
xen build/install system.

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] Re: [PATCH] Fixes for build/install system, Christoph Egger <=