WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] vtd: fix multiple Dom0 S3 on hosts that support Queu

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] vtd: fix multiple Dom0 S3 on hosts that support Queued Invalidation.
From: "Cui, Dexuan" <dexuan.cui@xxxxxxxxx>
Date: Fri, 27 Mar 2009 16:10:19 +0800
Accept-language: zh-CN, en-US
Acceptlanguage: zh-CN, en-US
Cc:
Delivery-date: Fri, 27 Mar 2009 01:13:02 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcmuD/zliNKAqj68QeahK+i9mchingAoDyWQ
Thread-topic: [PATCH] vtd: fix multiple Dom0 S3 on hosts that support Queued Invalidation.
On such hosts we can't do multiple Dom0 S3 when VT-d is enabled.
The cause is: during the first S3 resume, init_vtd_hw() initializes the
invalidation function pointers to the register-based ones and later
enable_qinval() forgets to overwrite the flush function pointers to
queued-based ones, so actually Queued Invalidaton is enabled, but we actually
use the register-based invalidation function! Later during the second Dom0 S3,
in iommu_suspend() -> iommu_flush_all(), we try to use the register-based
invalidation functions to perform global flush while Queued Invalidation is
enabed, and this can cause a host reset because VT-d spec says: when the
queued invalidation is enabled, software must submit invalidation commands only
through the IQ (and not through any invalidation command registers).

The attached patch fixes the buggy enable_qinval(). And in iommu_resume(), we
invoke iommu_flush_all() for safety.

Signed-off-by: Dexuan Cui <dexuan.cui@xxxxxxxxx>

Attachment: fix_qi_flush_functiones.patch
Description: fix_qi_flush_functiones.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] vtd: fix multiple Dom0 S3 on hosts that support Queued Invalidation., Cui, Dexuan <=