WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH]ioemu: fix buffer overflow of vslots

To: Simon Horman <horms@xxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH]ioemu: fix buffer overflow of vslots
From: "Cui, Dexuan" <dexuan.cui@xxxxxxxxx>
Date: Thu, 26 Mar 2009 13:29:49 +0800
Accept-language: zh-CN, en-US
Acceptlanguage: zh-CN, en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Delivery-date: Wed, 25 Mar 2009 22:31:58 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20090326051657.GE24011@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <EADF0A36011179459010BDF5142A45750FA04265@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20090326051657.GE24011@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acmt0hnmn6jUxrZBT6WqxdugAlj1YAAAaO2w
Thread-topic: [Xen-devel] [PATCH]ioemu: fix buffer overflow of vslots
Simon Horman wrote:
>> +    if ( vslots == NULL )
>> +    {
>> +        status = -1;
> 
> Status is already -1 at this point.

Oh, a little redundant... :-)

> 
>> +        goto err;
>> +    }
>> 
>>      /* Assign given devices to guest */
>>      while ( next_bdf(&direct_pci_p, &seg, &b, &d, &f, &opt) )


Thanks,
-- Dexuan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>