Re: [Xen-devel] [PATCH] fs-backend: fix compile problems

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

Boris Derzhavets wrote:

> Removed unresolved reference in
> /usr/src/xen-unstable.hg/tools/ioemu-dir/vl.c:5898: undefined reference
> to `pci_emulation_add'
> 
> /*    for (i = 0; i < nb_pci_emulation; i++) {
>         if(pci_emulation_add(pci_emulation_config_text[i]) < 0) {
>             fprintf(stderr, "Warning: could not add PCI device %s\n",
>                     pci_emulation_config_text[i]);
>         }
>     }
> */
> 
> "make tools" completed OK.
> Is it acceptable ?
> 



I think we are missing an ifdef CONFIG_PASSTHROUGH


diff --git a/vl.c b/vl.c
index 9b9f7d5..6c0ffb3 100644
--- a/vl.c
+++ b/vl.c
@@ -5894,12 +5894,14 @@ int main(int argc, char **argv, char **envp)
         }
     }
 
+#ifdef CONFIG_PASSTHROUGH
     for (i = 0; i < nb_pci_emulation; i++) {
         if(pci_emulation_add(pci_emulation_config_text[i]) < 0) {
             fprintf(stderr, "Warning: could not add PCI device %s\n",
                     pci_emulation_config_text[i]);
         }
     }
+#endif
 
     if (strlen(direct_pci_str) > 0)
         direct_pci = direct_pci_str;

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel