Re: [Xen-devel] [Patch] avoid deadlock during console output

[Juergen Gross <juergen.gross@xxxxxxxxxxxxxxxxxxx>]

Keir Fraser wrote:
> On 06/03/2009 08:46, "Juergen Gross" <juergen.gross@xxxxxxxxxxxxxxxxxxx>
> wrote:
> 
>> to dump the schedulers run-queues. On my 4-core machine I need only about 5
>> calls to stop the machine.
>>
>> The attached patch solves the problem by avoiding sending the event in
>> critical paths.
> 
> Ugly. Instead we can defer the dom0 notification to a tasklet. I'll make a
> patch for that myself.

Hmm, do you think your patch is okay?
tasklet_schedule is taking another lock and uses BUG_ON then...
I would suggest to modify tasklet_schedule:

        if ( !t->is_scheduled && !t->is_running )
        {
            if (!list_empty(&t->list))
            {
                spin_unlock_irqrestore(&tasklet_lock, flags);
                BUG();
            }
            list_add_tail(&t->list, &tasklet_list);
        }

Juergen

-- 
Juergen Gross                             Principal Developer
IP SW OS6                      Telephone: +49 (0) 89 636 47950
Fujitsu Siemens Computers         e-mail: juergen.gross@xxxxxxxxxxxxxxxxxxx
Otto-Hahn-Ring 6                Internet: www.fujitsu-siemens.com
D-81739 Muenchen         Company details: www.fujitsu-siemens.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel