WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] Blkif regular expression fix

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] Blkif regular expression fix
From: Michal Novotny <minovotn@xxxxxxxxxx>
Date: Thu, 05 Mar 2009 15:14:36 +0100
Delivery-date: Thu, 05 Mar 2009 06:15:02 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.19 (X11/20090105)
Hello everybody,
I have created a patch for blkif.py to support only hd[a-t] devices from 1 to 63. There was missing $ sign at the end of the regular expression and therefore even hda100 was able to be attached but not working correctly. Anyway hda989898 was able to be mounted but it crashed guest kernel. This patch solves this issue...

Michal

Signed-off-by: Michal Novotny <minovotn@xxxxxxxxxx>
diff -up xen-3.1.0-src/tools/python/xen/util/blkif.py.bz475433 
xen-3.1.0-src/tools/python/xen/util/blkif.py
--- xen-3.1.0-src/tools/python/xen/util/blkif.py.bz475433       2009-03-05 
14:51:35.000000000 +0100
+++ xen-3.1.0-src/tools/python/xen/util/blkif.py        2009-03-05 
14:51:50.000000000 +0100
@@ -29,7 +29,7 @@ def blkdev_name_to_number(name):
 
     if re.match( '/dev/sd[a-p]([1-9]|1[0-5])?$', n):
         devnum = 8 * 256 + 16 * (ord(n[7:8]) - ord('a')) + int(n[8:] or 0)
-    elif re.match( '/dev/hd[a-t]([1-9]|[1-5][0-9]|6[0-3])?', n):
+    elif re.match( '/dev/hd[a-t]([1-9]|[1-5][0-9]|6[0-3])?$', n):
         ide_majors = [ 3, 22, 33, 34, 56, 57, 88, 89, 90, 91 ]
         major = ide_majors[(ord(n[7:8]) - ord('a')) / 2]
         minor = ((ord(n[7:8]) - ord('a')) % 2) * 64 + int(n[8:] or 0)
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] Blkif regular expression fix, Michal Novotny <=