 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] pygrub: parse xen module option in grub
| To: | Wei Kong <weikong.cn@xxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] pygrub: parse xen module option in grub |
| From: | John Levon <levon@xxxxxxxxxxxxxxxxx> |
| Date: | Thu, 19 Feb 2009 21:55:05 -0500 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Thu, 19 Feb 2009 18:55:46 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <fac556d20902191840j79bcb2ccwcb32e80b4369cf08@xxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <fac556d20902191840j79bcb2ccwcb32e80b4369cf08@xxxxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| User-agent: | Mutt/1.5.9i |
On Fri, Feb 20, 2009 at 10:40:14AM +0800, Wei Kong wrote: > Add function for GrubConf to parse xen module option in grub. Why? > Pygrub should pass args as domUloader did. domUloader was never in the tree. > - sxp += "(args \"%s\")" % chosencfg["args"] > + sxp += "(args \"%s %s\")" % (chosencfg["args"], incfg["args"]) Are you trying to let the user add arguments to the ones specified in grub? Why? The patch is wrong anyway, you can't just add on the incoming args for Solaris at least. At the very least you need to add the args only when run_grub() is called. john _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | RE: [Xen-devel] Re: [RFC] RAS(Part II)--MCA enalbing in XEN, Jiang, Yunhong |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH] pygrub: parse xen module option in grub, Wei Kong |
| Previous by Thread: | [Xen-devel] [PATCH] pygrub: parse xen module option in grub, Wei Kong |
| Next by Thread: | Re: [Xen-devel] [PATCH] pygrub: parse xen module option in grub, Wei Kong |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
