WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] Handle older Xen save files where arbytes are in the

To: "Zhai, Edwin" <edwin.zhai@xxxxxxxxx>
Subject: [Xen-devel] [PATCH] Handle older Xen save files where arbytes are in the wrong format.
From: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Date: Thu, 12 Feb 2009 13:45:50 +0000
Cc: "Keir.Fraser@xxxxxxxxxxxx" <Keir.Fraser@xxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 12 Feb 2009 05:46:22 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4994267D.5020903@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4994267D.5020903@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.17 (2007-11-01)
At 08:39 -0500 on 12 Feb (1234427949), Zhai, Edwin wrote:
>  From r17037, hvm_{get|set}_segment_register are used to save/restore
> the VMCS segment register. But they introduce new compat image format
> for xx_arbytes, i.e.
> reg->attr.bytes = (attr & 0xff) | ((attr >> 4) & 0xf00);
> 
> This caused wrong VMCS setting for arbytes when restore old image on
> new changeset.
> 
> How to fix it? Can we determine it's old format if bit 12~15 of
> cs_arbytes is not zero, and then translate it?

Yes -- sorry, I thought I'd already sent this patch. 

Signed-off-by: Tim Deegan <Tim.Deegan@xxxxxxxxxx>

Attachment: old-arbytes
Description: Text document

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel