WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 3/5] setup_irq/request_irq/free_irq fixups

To: Espen Skoglund <espen.skoglund@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 3/5] setup_irq/request_irq/free_irq fixups
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Fri, 06 Feb 2009 11:34:46 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 06 Feb 2009 03:35:16 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <18828.7684.439394.971077@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcmITulRo+oOFXZyQk+2IfVDC3X+QQ==
Thread-topic: [Xen-devel] [PATCH 3/5] setup_irq/request_irq/free_irq fixups
User-agent: Microsoft-Entourage/12.15.0.081119
On 06/02/2009 11:24, "Espen Skoglund" <espen.skoglund@xxxxxxxxxxxxx> wrote:

>>> Make setup_irq/request_irq/free_irq take vector param instead of
>>> irq param
> 
>> Do you really think that's an improvement?
> 
> Yes.  Some interrupts, e.g., for handling IOMMU faults, do not need to
> be associated with a pirq.  They just need to have a vector allocated
> to them.  The way this used to work, the caller would have to invent a
> IRQ to go with the vector (typically irq := vector) befor calling the
> function.

My reading of the patch was that you simply pushed irq_to_vector() out into
every caller. I therefore just took the ->shutdown() fix for free_irq() and
dropped the rest. I checked in the rest of your patches.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>