WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel][PATCH 2/2] Enhance MTRR/PAT virtualization for EPT & VT-

To: "Xin, Xiaohui" <xiaohui.xin@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel][PATCH 2/2] Enhance MTRR/PAT virtualization for EPT & VT-d enabled both
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 22 Jan 2009 13:13:40 +0000
Cc:
Delivery-date: Thu, 22 Jan 2009 05:14:05 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C85CEDA13AB1CF4D9D597824A86D2B9001C532F7DA@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acl8dpbanCB0DwW8TGmTMMt32OWsQQAA8//QAAMKI+cAAM3KkAACXeGI
Thread-topic: [Xen-devel][PATCH 2/2] Enhance MTRR/PAT virtualization for EPT & VT-d enabled both
User-agent: Microsoft-Entourage/12.14.0.081024
On 22/01/2009 12:37, "Xin, Xiaohui" <xiaohui.xin@xxxxxxxxx> wrote:

> I knew that. But since at last we should add the parameter in ept_set_entry()
> which will then taint p2m_set_entry() to add an unused parameter, and the
> parameter is meaningless at all in shadow mode. And the flag is used in the
> same way as the flag is_in_uc_mode in hvm_set_uc_mode().

That's not true, since is_in_uc_mode is a state which persists beyond any
single function's scope. It is a reflection of a real aspect of guest state.

> Do you like to add a parameter in set-entry() and then ept_set_entry() and
> p2m_set_entry()?

This is not necessary. Rename ept_set_entry() to something else (e.g.,
__ept_set_entry() if you can't think of anything better), taking this new
parameter. Then create a new ept_set_entry(), calling your renamed original
function, passing a default value for the new parameter.

This can work because the vmx_set_uc_mode() calls ept_* functions directly,
and hence having this parameter configurable via the generic p2m interface
is not necessary (as far as I can see). Only callers of ept_set_entry()
which need to specify the new parameter need to call the renamed function,
and I think all such callers are in vmx/ept code.

And please add a comment to give some idea of what this new parameter
actually means and represents (something higher level than it being an
optimisation hack :-).

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel