WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] pv_ops dom0 x86_32 PAE kernel buildlog of missingsymbols

To: "Marc - A. Dahlhaus [ Administration | Westermann GmbH ]" <mad@xxxxxx>
Subject: Re: [Xen-devel] pv_ops dom0 x86_32 PAE kernel buildlog of missingsymbols...
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Wed, 17 Dec 2008 15:55:37 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 17 Dec 2008 07:56:06 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1229528947.7033.16.camel@marc>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <49402FA9.80403@xxxxxx> <1228996810.19933.48.camel@xxxxxxxxxxxxxxxxxxxxxx> <4941216C.76E4.0078.0@xxxxxxxxxx> <1229528947.7033.16.camel@marc>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Wed, 2008-12-17 at 16:49 +0100, Marc - A. Dahlhaus [ Administration |
Westermann GmbH ] wrote:
> Hello Jan,
> hello Ian,
> 
> 
> i did another build today (c/s 2239) and can confirm that only the
> following two warnings are left:
> 
> ERROR: "blk_put_queue" [drivers/xen/blkback/blkbk.ko] undefined!
> ERROR: "blk_get_queue" [drivers/xen/blkback/blkbk.ko] undefined!
> 
> Should i give Jan's patch a try or is another patch to address this
> errors planed to be added to the patchset soon?

I say just make these symbols EXPORT_SYMBOL_GPL or build blkback
statically for the time being.

The exports were removed upstream because there was no in-tree module
users but if we are adding one then reverting that could be acceptable.
If that turns out to be unacceptable upstream then we could consider
Jan's patch.

Ian.

> 
> I ask this because i have some spare time and hardware over the weekend
> i could use to do some boot tests. Maybe i can provide some valuable
> logs then...
> 
> 
> Marc
> 
> Am Donnerstag, den 11.12.2008, 13:19 +0000 schrieb Jan Beulich:
> > >>> Ian Campbell <Ian.Campbell@xxxxxxxxxx> 11.12.08 13:00 >>>
> > >ERROR: "alloc_empty_pages_and_pagevec" [drivers/xen/blkback/blkbk.ko]
> > >undefined!
> > >ERROR: "blk_put_queue" [drivers/xen/blkback/blkbk.ko] undefined!
> > >ERROR: "free_empty_pages_and_pagevec" [drivers/xen/blkback/blkbk.ko] 
> > >undefined!
> > >ERROR: "blk_get_queue" [drivers/xen/blkback/blkbk.ko] undefined!
> > >ERROR: "set_phys_to_machine" [drivers/xen/blkback/blkbk.ko] undefined!
> > >
> > >The *_empty_pages_and_pagevec and set_phys_to_machine are probably fair
> > >game for an EXPORT_SYMBOL_GPL. The two blk subsystem ones are
> > >suspicious, the fact that they aren't already exported suggests there is
> > >another API we should be using.
> > 
> > I'd be curious if you can find one - in our 2.6.25 merge patch the only way
> > to address this was to open-code what they do in blkback (short of re-adding
> > the exports):
> > 
> > --- head-2008-12-08.orig/drivers/xen/blkback/blkback.c      2008-12-08 
> > 13:24:54.000000000 +0100
> > +++ head-2008-12-08/drivers/xen/blkback/blkback.c   2008-12-08 
> > 13:24:57.000000000 +0100
> > @@ -148,7 +148,7 @@ static void unplug_queue(blkif_t *blkif)
> >             return;
> >     if (blkif->plug->unplug_fn)
> >             blkif->plug->unplug_fn(blkif->plug);
> > -   blk_put_queue(blkif->plug);
> > +   kobject_put(&blkif->plug->kobj);
> >     blkif->plug = NULL;
> >  }
> >  
> > @@ -159,7 +159,8 @@ static void plug_queue(blkif_t *blkif, s
> >     if (q == blkif->plug)
> >             return;
> >     unplug_queue(blkif);
> > -   blk_get_queue(q);
> > +   WARN_ON(test_bit(QUEUE_FLAG_DEAD, &q->queue_flags));
> > +   kobject_get(&q->kobj);
> >     blkif->plug = q;
> >  }
> >  
> > 
> > Jan
> 
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel