WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] x86: fix the potential of encountering panic "IO

To: Jan Beulich <jbeulich@xxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] x86: fix the potential of encountering panic "IO-APIC+ timer doesn't work! ..."
From: Ingo Molnar <mingo@xxxxxxx>
Date: Fri, 12 Dec 2008 11:06:38 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 12 Dec 2008 02:07:06 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <49424210.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4940FBFA.76E4.0078.0@xxxxxxxxxx> <20081212091329.GG25106@xxxxxxx> <49424210.76E4.0078.0@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
* Jan Beulich <jbeulich@xxxxxxxxxx> wrote:

> >>> Ingo Molnar <mingo@xxxxxxx> 12.12.08 10:13 >>>
> >
> >* Jan Beulich <jbeulich@xxxxxxxxxx> wrote:
> >
> >> >From all I can tell, the below reproduced full description of the
> >> original Linux patch applies to Xen, too - at least in the watchdog 
> >> enabled case IRQs can be enabled when entering setup_IO_APIC(). My 
> >> attention to this change really got caught just by the fact that it got 
> >> added to our (2.6.16-based) SLE10 kernel pretty recently.
> >
> >note that we had to revert that eventually. The real solution is an 
> >array of fixes from Maciej spread out over many months.
> 
> What do you mean by 'eventually'? 2.6.28-rc8 still has this code, and 
> so does -tip.

argh. Different io-apic breakage. I shouldnt remember patches by their 
subject lines ;-)

Sorry about the confusion - Jan is right and my fix ported to Xen is good 
;-)

the point about the other breakages remains: for the best bootup ratio 
you'll want to pick up everything from the (now unified) 
arch/x86/kernel/io_apic.c.

        Ingo

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel