This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH] libxc: Fix memory leak in zlib usage

To: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] libxc: Fix memory leak in zlib usage
From: Kevin Wolf <kwolf@xxxxxxx>
Date: Tue, 09 Dec 2008 18:42:49 +0100
Delivery-date: Tue, 09 Dec 2008 09:38:48 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird (X11/20080922)
Any call to inflate() must be followed by inflateEnd(), otherwise the
internal zlib state is leaked.

Signed-off-by: Kevin Wolf <kwolf@xxxxxxx>
Index: xen-unstable.hg/tools/libxc/xc_dom_core.c
--- xen-unstable.hg.orig/tools/libxc/xc_dom_core.c
+++ xen-unstable.hg/tools/libxc/xc_dom_core.c
@@ -244,6 +244,7 @@ int xc_dom_do_gunzip(void *src, size_t s
         return -1;
     rc = inflate(&zStream, Z_FINISH);
+    inflateEnd(&zStream);
     if ( rc != Z_STREAM_END )
Index: xen-unstable.hg/tools/libxc/xg_private.c
--- xen-unstable.hg.orig/tools/libxc/xg_private.c
+++ xen-unstable.hg/tools/libxc/xg_private.c
@@ -131,6 +131,7 @@ char *xc_inflate_buffer(const char *in_b
     /* Inflate in one pass/call */
     sts = inflate(&zStream, Z_FINISH);
+    inflateEnd(&zStream);
     if ( sts != Z_STREAM_END )
         ERROR("inflate failed, sts %d\n", sts);
Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] libxc: Fix memory leak in zlib usage, Kevin Wolf <=