This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [RFC][PATCH] scheduler: credit scheduler for client virt

To: NISHIGUCHI Naoki <nisiguti@xxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [RFC][PATCH] scheduler: credit scheduler for client virtualization
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 03 Dec 2008 09:16:18 +0000
Cc: Ian.Pratt@xxxxxxxxxxxxx, disheng.su@xxxxxxxxx
Delivery-date: Wed, 03 Dec 2008 01:16:48 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <49364960.2060101@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AclVJ8yDUyIN0AFLYk6sVG+kFiNlHg==
Thread-topic: [Xen-devel] [RFC][PATCH] scheduler: credit scheduler for client virtualization
User-agent: Microsoft-Entourage/
On 03/12/2008 08:54, "NISHIGUCHI Naoki" <nisiguti@xxxxxxxxxxxxxx> wrote:

> Please review this patch.
> Any comments are appreciated.

Don't hack it into the existing sched_credit.c unless you are really sharing
significant amounts of stuff (which it looks like you aren't?).
sched_bcredit.c would be a cleaner name if there's no sharing. Is a new
scheduler necessary -- could the existing credit scheduler be generalised
with your boost mechanism to be suitable for both client and server?

The issue with multiple schedulers is that it's most likely the non-default
will not be tested, used or maintained. The default credit scheduler gets
little enough love as it is, and it's really the only sensible scheduler to
choose now (SEDF is not great -- good example of a rotten non-default

 -- Keir

Xen-devel mailing list