 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] enable hpet after s3 resume
| To: | "Tian, Kevin" <kevin.tian@xxxxxxxxx>, "Lu, Guanqun" <guanqun.lu@xxxxxxxxx>, xen-devel组 <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] enable hpet after s3 resume |
| From: | Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
| Date: | Tue, 18 Nov 2008 10:15:38 +0000 |
| Cc: | |
| Delivery-date: | Tue, 18 Nov 2008 02:16:02 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <0A882F4D99BBF6449D58E61AAFD7EDD601E23B27@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AclJXv30XOVi3v8HTtK9waDYksrQrwABRIDOAAAh8gAAAICgnw== |
| Thread-topic: | [Xen-devel] [PATCH] enable hpet after s3 resume |
| User-agent: | Microsoft-Entourage/11.4.0.080122 |
On 18/11/08 10:04, "Tian, Kevin" <kevin.tian@xxxxxxxxx> wrote: >> The hpet.c changes are ugly. What's so special about >> hpet_broadcast_init() >> that it needs to distinguish between boot and S3 resume? In >> the latter case >> it executes with APs still offline and IRQs disabled, so >> what's wrong with >> rewriting the fixmap entry, re-initialising the spinlock and hpet_event >> info? > > Is it safe to set fixmap entry twice without unmap? If yes, then > agree same logic applies to both boot and S3 resume. Yes, all it does is write a pte. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] Patch: implementing least priority interrupt routing, Keir Fraser |
|---|---|
| Next by Date: | [Xen-devel] xenfb issuing notify_remote_via_irq() too early, Jan Beulich |
| Previous by Thread: | RE: [Xen-devel] [PATCH] enable hpet after s3 resume, Tian, Kevin |
| Next by Thread: | Re: [Xen-devel] [PATCH] enable hpet after s3 resume, Guanqun Lu |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
