WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [xen-devel][PATCH] Battery Management qemu patch

To: "Ian Jackson" <Ian.Jackson@xxxxxxxxxxxxx>
Subject: RE: [xen-devel][PATCH] Battery Management qemu patch
From: "Kamala Narasimhan" <Kamala.Narasimhan@xxxxxxxxxx>
Date: Tue, 21 Oct 2008 15:14:43 -0400
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 21 Oct 2008 12:15:10 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <18685.41084.763266.275822@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <0519110A9448BC429B231AD118D7270805BFFA0F@xxxxxxxxxxxxxxxxxxxxxx> <18685.41084.763266.275822@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AckzX0k8EwWKQZyUTZKimuru0byzXgAUPebA
Thread-topic: [xen-devel][PATCH] Battery Management qemu patch
I have attached with this email a revised patch that should address all
the issues mentioned below.  Please let me know if you have further
suggestions.

Signed-off-by: Kamala Narasimhan <kamala.narasimhan@xxxxxxxxxx>

Thanks,
Kamala

> -----Original Message-----
> From: Ian Jackson
> Sent: Tuesday, October 21, 2008 5:27 AM
> To: Kamala Narasimhan
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [xen-devel][PATCH] Battery Management qemu patch
> 
> Kamala Narasimhan writes ("[xen-devel][PATCH] Battery Management qemu
> patch"):
> > Attached is the qemu side change for battery support within HVM
guest.
> > This will be followed by a xen power management daemon patch.
> 
> You have added some functions to xenstore.c, but these functions do
> not encapsulate the xenstore interaction and structure for the power
> management setup.  But they're just plain xenstore accessors which
> seem a bit pointless really.  Instead you should move the knowledge
> about the xenstore structure, to xenstore.c, and provide a structured
> interface between the two components.
> 
> This will involve moving much of the contents of
> get_battery_data_from_xenstore and also the relevant part of
> battery_port_1_writeb.  The point is to ensure that nothing outside
> xenstore.c needs to know about the structure and semantics of xenstore
> (including the paths, the value formats, and the temporal/causal
> relationships between the keys and values).  This will make it easier
> when these changes have to go upstream.
> 
> Why have you selected CAPITAL LETTERS for your new xenstore path ?
> Very little else in xenstore uses caps and I think it would probably
> be better avoided here.
> 
> 
> The patch contains a diff to the file `i386-dm/Makefile' but that is a
> symlink to Makefile.target created by the configuration step (invoked
> in our builds as xen-xetup).  Makefile.target has the same diff.  This
> makes the patch slightly troublesome to apply.
> 
> 
> Also, if you need to add object files please add them in
> xen-hooks.mak, not directly in Makefile.target.  That way I won't have
> to deal with merge conflicts.
> 
> 
> Ian.

Attachment: battery-mgmt-git-changes-rev1.diff
Description: battery-mgmt-git-changes-rev1.diff

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>