WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] conditionalize PCI reassign code

To: Jan Beulich <jbeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] conditionalize PCI reassign code
From: "Zhao, Yu" <yu.zhao@xxxxxxxxx>
Date: Fri, 17 Oct 2008 15:27:36 +0800
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Fri, 17 Oct 2008 00:28:15 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <48F85833.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <48F4BD46.76E4.0078.0@xxxxxxxxxx> <48F7FBE9.6030207@xxxxxxxxx> <48F85833.76E4.0078.0@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.17 (Windows/20080914)
Jan Beulich wrote:
"Zhao, Yu" <yu.zhao@xxxxxxxxx> 17.10.08 04:43 >>>
There is build error (c/s 701) with this patch, please take a look.

This is why I always include

As usual, written and tested on 2.6.27 and made apply to the 2.6.18
tree without further testing.

I'm making a best effort attempt at getting things in proper state for that
tree, but time-wise can't afford full validation. But I always assumed that
if this appears in the real (not the staging) tree, it at least survived
building in Citrix' trees - is that not correct, Keir?

As you observed the build error - why don't you provide at least the
error the compiler generated? That might make it possible to provide a
fix quickly.

+#ifdef CONFIG_PCI_REASSIGN
 extern int reassign_resources;
 extern int is_reassigndev(struct pci_dev *dev);
 extern void pci_update_bridge(struct pci_dev *dev, int resno);
+#else
+#define reassign_resources 0
+#define is_reassigndev(dev) 0
+#endif

When the CONFIG_PCI_REASSIGN is not set, e.g., a domU kernel, the following line fails to be compiled (drivers/pci/quirks.c):

int reassign_resources = 0;


Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel