xen-devel

[Top] [All Lists]

[Xen-devel] [PATCH] x86: propagate return value of alloc_l1_table()

from [Jan Beulich]

[Permanent Link][Original]

To:	<xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	[Xen-devel] [PATCH] x86: propagate return value of alloc_l1_table()
From:	"Jan Beulich" <jbeulich@xxxxxxxxxx>
Date:	Mon, 13 Oct 2008 11:37:06 +0100
Delivery-date:	Mon, 13 Oct 2008 03:36:43 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

A blatant mistake of mine resulted in the return value of alloc_l1_table to
be ignored with the preemptable page table update changes.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

Index: 2008-09-19/xen/arch/x86/mm.c
===================================================================
--- 2008-09-19.orig/xen/arch/x86/mm.c   2008-09-19 14:00:01.000000000 +0200
+++ 2008-09-19/xen/arch/x86/mm.c        2008-10-13 12:07:13.000000000 +0200
@@ -1883,8 +1883,7 @@ static int alloc_page_type(struct page_i
     switch ( type & PGT_type_mask )
     {
     case PGT_l1_page_table:
-        alloc_l1_table(page);
-        rc = 0;
+        rc = alloc_l1_table(page);
         break;
     case PGT_l2_page_table:
         rc = alloc_l2_table(page, type, preemptible);




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] x86: propagate return value of alloc_l1_table(), Jan Beulich <=

Previous by Date:	Re: [Xen-devel] size_t and printk and Xen, Christoph Egger
Next by Date:	[Xen-devel] Xen and tickless Linux, Thomas Pfeuffer
Previous by Thread:	[Xen-devel] [PATCH] Hyper-V guest interface support with small set of enlightenments, Keir Fraser
Next by Thread:	[Xen-devel] Xen and tickless Linux, Thomas Pfeuffer
Indexes:	[Date] [Thread] [Top] [All Lists]