WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] fix 3.3-testing c/s 18434

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] fix 3.3-testing c/s 18434
From: Jim Fehlig <jfehlig@xxxxxxxxxx>
Date: Fri, 10 Oct 2008 13:09:34 -0600
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 10 Oct 2008 12:10:08 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C514C7AA.1E0A7%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C514C7AA.1E0A7%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 1.5.0.8 (X11/20060911)
Keir Fraser wrote:
> On 9/10/08 23:02, "Jim Fehlig" <jfehlig@xxxxxxxxxx> wrote:
>
>   
>> Missed that, sorry.
>>
>> I've also found that this c/s causes /local/domain/0/backend/{vkbd, vfb,
>> console} paths to leak :(.  Patch attached.
>>     
>
> A major point of the patch was to stop reading the backend link from the
> frontend directory.

Ah, right.  I should have looked at the patch more closely :-/

>  Is the problem that /vm/... is getting deleted too
> early? Could we delay it?
>   

Turns out that we were just constructing the path incorrectly.  Patch
attached.

Thanks,
Jim


    Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxxxx>

diff -r 39f6f421eac1 tools/python/xen/xend/server/DevController.py
--- a/tools/python/xen/xend/server/DevController.py     Fri Oct 10 10:15:58 
2008 +0100
+++ b/tools/python/xen/xend/server/DevController.py     Fri Oct 10 13:04:54 
2008 -0600
@@ -257,7 +257,7 @@ class DevController:
 
         if force:
             frontpath = self.frontendPath(dev)
-            backpath = self.readVm(devid, "backend")
+            backpath = self.readVm(dev, "backend")
             if backpath:
                 xstransact.Remove(backpath)
             xstransact.Remove(frontpath)
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>