 Home |
Products |
Support |
Community |
News |
xen-devel
[Xen-devel] Re: [PATCH] Share the IO_APIC_route_entry with iosapic
| To: | "Cui, Dexuan" <dexuan.cui@xxxxxxxxx>, "'xen-devel@xxxxxxxxxxxxxxxxxxx'" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | [Xen-devel] Re: [PATCH] Share the IO_APIC_route_entry with iosapic |
| From: | Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
| Date: | Sun, 28 Sep 2008 10:36:04 +0100 |
| Cc: | |
| Delivery-date: | Sun, 28 Sep 2008 02:36:21 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <F4AE3CDE26E0164D9E990A34F2D4E0DF088794B753@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AckgiO9bcpoCwP60QhSSqGPREIpSFQAkJdlgAAYECKAABwJS6w== |
| Thread-topic: | [PATCH] Share the IO_APIC_route_entry with iosapic |
| User-agent: | Microsoft-Entourage/11.4.0.080122 |
If the code using this definition will be shared too, that's one thing. If you're actually going to put all the code under arch/ia64 (which you seem to imply), then duplicating this structure in include/asm-ia64 is okay. It's not like it's changing, ever. I personally think that striving to share architectural definitions in all cases, even where that may twist the header #includes, is not necessarily a good idea. So it depends what your end goal is. -- Keir On 28/9/08 07:52, "Cui, Dexuan" <dexuan.cui@xxxxxxxxx> wrote: > The patch moves the struct IO_APIC_route_entry to a common place. > This allows us to share the struct with iosapic. > > Thanks, > -- Dexuan > > > _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] Re: super page with live migration, Keir Fraser |
|---|---|
| Next by Date: | RE: [Xen-devel] Re: super page with live migration, Ian Pratt |
| Previous by Thread: | [Xen-devel] [PATCH] Share the IO_APIC_route_entry with iosapic, Cui, Dexuan |
| Next by Thread: | [Xen-devel] Stubdom and blktap, Yang, Xiaowei |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
