WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Xend: Fix Setting up Platform Parameters

To: Yosuke Iwamatsu <y-iwamatsu@xxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Xend: Fix Setting up Platform Parameters
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 13 Aug 2008 13:29:12 +0100
Cc:
Delivery-date: Wed, 13 Aug 2008 05:29:38 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <48A2CE4C.1080803@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acj9QDDjbyjOeGkzEd2S1gAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] Xend: Fix Setting up Platform Parameters
User-agent: Microsoft-Entourage/11.4.0.080122
So setting self['platform']['loader'] to '' instead of None can break
booting? How?

 -- Keir

On 13/8/08 13:06, "Yosuke Iwamatsu" <y-iwamatsu@xxxxxxxxxxxxx> wrote:

> Make sure that 'PV_kernel' config param is not blank when assigning it
> to 'loader' param. This fixes a failure of 'xm create' via xen-api.
> 
> Signed-off-by: Yosuke Iwamatsu <y-iwamatsu@xxxxxxxxxxxxx>
> 
> diff -r 2c63cf7b042d tools/python/xen/xend/XendConfig.py
> --- a/tools/python/xen/xend/XendConfig.py   Tue Aug 12 10:23:34 2008 +0100
> +++ b/tools/python/xen/xend/XendConfig.py   Wed Aug 13 20:43:41 2008 +0900
> @@ -448,7 +448,7 @@ class XendConfig(dict):
>                  self['platform']['hpet'] = 0
>              if 'loader' not in self['platform']:
>                  # Old configs may have hvmloader set as PV_kernel param
> -                if self.has_key('PV_kernel'):
> +                if self.has_key('PV_kernel') and self['PV_kernel'] != '':
>                      self['platform']['loader'] = self['PV_kernel']
>                      self['PV_kernel'] = ''
>                  else:
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>