WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [Qemu-devel] [PATCH 01/11] Handle terminating signals.

To: qemu-devel@xxxxxxxxxx
Subject: [Xen-devel] Re: [Qemu-devel] [PATCH 01/11] Handle terminating signals.
From: Gerd Hoffmann <kraxel@xxxxxxxxxx>
Date: Mon, 11 Aug 2008 21:52:54 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 11 Aug 2008 12:53:16 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <48A09296.2040406@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1218457970-11707-1-git-send-email-kraxel@xxxxxxxxxx> <1218457970-11707-2-git-send-email-kraxel@xxxxxxxxxx> <48A09296.2040406@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.16 (X11/20080723)
Anthony Liguori wrote:
>> --- a/sdl.c
>> +++ b/sdl.c
>> @@ -476,10 +476,8 @@ static void sdl_refresh(DisplayState *ds)
>>                  sdl_process_key(&ev->key);
>>              break;
>>          case SDL_QUIT:
>> -            if (!no_quit) {
>> +            if (!no_quit)
>>                  qemu_system_shutdown_request();
>> -                vm_start();    /* In case we're paused */
>>   
> 
> I'm curious why this is no longer needed?

To avoid calling vm_start() from the signal handler main_loop() got an
additional check so qemu_system_shutdown_request() works even when the
vm is in stopped state.

[ Hmm, cut&paste -> changelog I guess ... ]

cheers,
  Gerd

-- 
http://kraxel.fedorapeople.org/xenner/

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel