|
|
![](http://www.xen.org/images/globals/pixel.gif) |
|
|
|
|
|
|
|
xen-devel
[Xen-devel] Re: [Qemu-devel] [PATCH 1/7] xen: groundwork for xen support
Blue Swirl wrote:
> On 8/4/08, Gerd Hoffmann <kraxel@xxxxxxxxxx> wrote:
>> - allow xenpv machines run without disk and kernel specified
>> by adding a nodisk_ok field to QEMUMachine.
>
> Nice idea, this would be a useful feature by itself.
Yes, some embedded devices probably can use that too according to the
source code comment. Guess thats why anthony suggested to do it that
way, and I liked the idea too, so I just did ;)
>> + $(XEN_OBJS) : CFLAGS += -Wall -Wmissing-prototypes -Wstrict-prototypes
>
> These aren't needed for Xen. Though I wonder why at least -Wall
> -Wstrict-prototypes could not be added globally.
IIRC I tried to turn them on globally and found myself swamped with
warnings. So I took the easy way out and enabled them only for the xen
bits I'm working on. I like those warnings, they catch sloppyness and
help writing clean code. They are in no way required though. We can
add them globally nevertheless, I can keep them as local patch, I don't
mind much.
>> + if (-1 != xen_present)
>
> This style looks alien to me. Do you really find it readable?
Bad habit. gcc warns these days on "if (foo = 42)", so the reason to
write "if (42 = foo)" is gone. I'm still doing that for -- say --
historical reasons?
cheers,
Gerd
--
http://kraxel.fedorapeople.org/xenner/
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
<Prev in Thread] |
Current Thread |
[Next in Thread>
|
- [Xen-devel] Re: [Qemu-devel] [PATCH 5/7] xen: add block device backend driver., (continued)
[Xen-devel] [PATCH 2/7] xen: backend driver core, Gerd Hoffmann
[Xen-devel] [PATCH 6/7] xen: add net backend driver., Gerd Hoffmann
[Xen-devel] [PATCH 4/7] xen: add framebuffer backend driver, Gerd Hoffmann
[Xen-devel] [PATCH 3/7] xen: add console backend driver., Gerd Hoffmann
[Xen-devel] [PATCH 1/7] xen: groundwork for xen support, Gerd Hoffmann
Message not available[Xen-devel] Re: [Qemu-devel] [PATCH 1/7] xen: groundwork for xen support,
Gerd Hoffmann <=
[Xen-devel] Re: [Qemu-devel] [PATCH 0/7] merge some xen bits into qemu, Anthony Liguori
[Xen-devel] Re: [Qemu-devel] [PATCH 0/7] merge some xen bits into qemu, Samuel Thibault
[Xen-devel] Re: [Qemu-devel] [PATCH 0/7] merge some xen bits into qemu, Gerd Hoffmann
[Xen-devel] Re: [Qemu-devel] [PATCH 0/7] merge some xen bits into qemu, Samuel Thibault
[Xen-devel] Re: [Qemu-devel] [PATCH 0/7] merge some xen bits into qemu, Gerd Hoffmann
[Xen-devel] Re: [Qemu-devel] [PATCH 0/7] merge some xen bits into qemu, Samuel Thibault
[Xen-devel] Re: [Qemu-devel] [PATCH 0/7] merge some xen bits into qemu, Samuel Thibault
[Xen-devel] Re: [Qemu-devel] [PATCH 0/7] merge some xen bits into qemu, Anthony Liguori
|
|
|
|
|