WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] gnttab_setup_table error case

To: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>, Qing He <qing.he@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] gnttab_setup_table error case
From: Diego Ongaro <diego.ongaro@xxxxxxxxxx>
Date: Thu, 31 Jul 2008 14:12:55 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 31 Jul 2008 06:13:38 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20080731085858.GE5427@implementation>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <489069F3.7070200@xxxxxxxxxx> <20080731020828.GA5842@ub-qhe2> <20080731085858.GE5427@implementation>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla-Thunderbird 2.0.0.14 (X11/20080509)
Samuel Thibault wrote:
> Qing He, le Thu 31 Jul 2008 10:08:28 +0800, a écrit :
>> On Wed, 2008-07-30 at 14:17 +0100, Diego Ongaro wrote:
>>> gnttab_setup_table should set an error status code if the gmfn it gets
>>> for a grant table page is invalid.
>>>
>>> I ran into this issue when I tried to set up the grant table during hvm
>>> domain creation, and it caused a BUG_ON later down the line. With this
>>> patch, the hypercall will gracefully fail instead.
>> Do you use 32bit guest on top of 64bit hypervisor?
> 
> No, just 64/64.

Well, no, it was 32 on 64 :)

>> Just curious, but why we want to call setup_table in HVM in the first
>> place. Since HVM has its isolated address space, it will always fail.
> 
> That was for his personal project.  The call was made from dom0.  The
> problem is that it triggers a BUG_ON, which we do not really want to
> happen :)

Keir's xen-unstable.hg cs 18177:9ee2e41a68a1 simply removed the
problematic BUG_ON, so at least userspace can now handle the error.

-Diego

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>