WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH][XEN] PV blk backend: Make 32bit PV guests work o

To: Christoph Egger <Christoph.Egger@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH][XEN] PV blk backend: Make 32bit PV guests work on 64bit PV Dom0
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Mon, 28 Jul 2008 13:23:00 +0100
Cc:
Delivery-date: Mon, 28 Jul 2008 05:23:26 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <200807281346.01560.Christoph.Egger@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcjwrKyM6zvA2FyfEd2NDAAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH][XEN] PV blk backend: Make 32bit PV guests work on 64bit PV Dom0
User-agent: Microsoft-Entourage/11.4.0.080122
Just do the same as we do in Linux and put these defs in your NetBSD private
header space.

 -- Keir

On 28/7/08 12:46, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

> 
> Hi,
> 
> Attached patch makes the PV block driver for 32bit PV guests working on
> 64bit PV Dom0.
> 
> In the io/blkif.h,  the 'id' field of
> struct blkif_request is 64bit, but on a LP32 system it's aligned on
> 32bits, while it'll be aligned to 64bits on a LP64 system. So on LP64 there'll
> be 4 bytes of padding between handle and id. The same is true for
> struct blkif_response: it's 11 bytes long, so will be aligned differently
> in the ring between a 32 and 64bit systems.
> 
> In order to fix this, attached patch introduces in the public headers,
> blkif_request/blkif_response, blkif_x86_32_request/blkif_x86_32_response
> and blkif_x86_64_request/blkif_x86_64_response.
> NetBSD is doing so io/blkif.h in the public headers, while Linux
> does so in include/xen/blkif.h in the linux sources. But the result is
> the same ...
> 
> Successfully tested with the combinations:
> 
> 64bit Dom0                32bit PAE PV guest
> NetBSD                       Linux
> Linux                            NetBSD
> 
> The combinations 64bit Dom0, 64bit PV DomU works with and without this patch.
> 
> Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel