WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] another xend race: qemu-dm versus device hotplug

To: John Levon <levon@xxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] another xend race: qemu-dm versus device hotplug
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Fri, 25 Jul 2008 14:26:07 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 25 Jul 2008 06:26:32 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20080724175820.GB21878@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <20080724175820.GB21878@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
John Levon writes ("[Xen-devel] another xend race: qemu-dm versus device 
hotplug"):
> +        status = xs_read(xsh, XBT_NULL, node, &len);
> +        if (status != NULL) {
> +            ret = (strcmp(status, "connected") == 0);
> +            goto out;
> +        }
> +        usleep(DEVICE_CREATE_INC);
> +        timeout -= DEVICE_CREATE_INC;
> +    } while (timeout > 0);

I agree that this is all a bit unpleasant really.  But waiting for the
device to be reported as ready in xenstore does seem more correct than
waiting for it to appear to stat.

The fly in the ointment is compatibility.  AFAICS this would make a
new qemu (one with this patch) not compatible with the old xend.  I
know it's a bit unfashionable but I'm trying to improve the
cross-version compatibility :-).

Perhaps xend could advertise in xenstore somehow that the new approach
was going to work ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>