WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] x86emulate - fix unintended writeback on cmp/test in

To: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] x86emulate - fix unintended writeback on cmp/test instructions
From: "Trolle Selander" <trolle.selander@xxxxxxxxx>
Date: Fri, 25 Jul 2008 12:00:45 +0100
Cc:
Delivery-date: Fri, 25 Jul 2008 04:01:07 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:mime-version:content-type; bh=0U47jG82TiAIim3iFQQYn6fXts4JY++XpftV7bn7ewA=; b=otMmfNLAzybT4vVaEe2Yj7dq/25xgmCrt8/DpMwJJawktqtHbjghwztX/7xysoLxu6 NrbH184DyCm6ofri8ryaLEVag2MvCPoAWxeCPKJ0nTwLPndAqPZF4g/1D2ZsURgkqp7n i0ydTx7M7j/AGqtr6EXc0R/wxoUTTD7mQTi8c=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:mime-version:content-type; b=FYGSYoRBDeYvJyc3qvFSG2a/J43xcQYGMzPYWtVzMquu11jzsQgzSA/qVrrLGYzAEN LjnDBJj9fRzUiTNvkWpS+CB/PGpWHBCaam5wUXWtQVSYFwdWDBgjpP/yxn6bwcRYMSHt 8cSonupAtYIi7kNfO4QN0eGlKQcS0/hlxjg8M=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
This patch fixes an issue when x86_emulate is called with force_writeback=1 set. It resulted in cmp and test instructions with memory operands to have the mem value written back after instruction emulation finished. This caused false alarms on writes to RO mem, and might have caused other issues if unintended writes occured to device registers in mmio space.

Signed-off-by: Trolle Selander <trolle.selander@xxxxxxxxxxxxx <mailto:trolle.selander@xxxxxxxxxxxxx>

Attachment: xen_x86_emulate_prevent_cmp_writeback.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] x86emulate - fix unintended writeback on cmp/test instructions, Trolle Selander <=