WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] barriers before {req/rsp}_cons = cons?

To: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] barriers before {req/rsp}_cons = cons?
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Mon, 21 Jul 2008 09:28:38 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 21 Jul 2008 01:29:03 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20080718193304.GI4576@implementation>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcjrC8V0BFBDQlb/Ed2RdQAX8io7RQ==
Thread-topic: [Xen-devel] barriers before {req/rsp}_cons = cons?
User-agent: Microsoft-Entourage/11.4.0.080122
On 18/7/08 20:33, "Samuel Thibault" <samuel.thibault@xxxxxxxxxxxxx> wrote:

>> Could you describe the race you believe is made possible by the absence of
>> the barrier?
> 
> It is very unlikely, but the write into req_cons could happen before
> actually doing the memcpy, and so another processor could try to reuse
> the same request slot.

req_cons is not shared with the frontend driver, and most accesses within
the backend are serialised within the transmit tasklet.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel