WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] pvSCSI: Sanity check for REPORT_LUN emulation

To: Jun Kamada <kama@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] pvSCSI: Sanity check for REPORT_LUN emulation
From: Steven Smith <steven.smith@xxxxxxxxxx>
Date: Fri, 18 Jul 2008 14:58:41 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 18 Jul 2008 06:59:12 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20080716105252.0274.EB2C8575@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20080716105252.0274.EB2C8575@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
> I will attach a patch in order to provide following.
> 
> - Sanity check for REPORT_LUN emulation.
Thank you, that's much better.

I have one slight issue with the new approach: if a REPORT_LUNS
command races with a LUN hot-add on the backend, you tell the frontend
that the command failed.  Might it be better to instead retry the
command on the backend?

It's pretty unlikely that anyone would actually hit this race, and the
current behaviour isn't completely unreasonable, but it seems like
retrying in the backend would be a bit more robust.  What do you
think?

Steven.

Attachment: signature.asc
Description: Digital signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel