WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel][PATCH] Fix the boot failure of xenU after destroying aHV

To: "Xu, Dongxiao" <dongxiao.xu@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel][PATCH] Fix the boot failure of xenU after destroying aHVM guest
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 16 Jul 2008 08:23:53 +0100
Cc: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Delivery-date: Wed, 16 Jul 2008 00:24:04 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <FF386CB4AE0E4648B0A96060EC00F36CC0EA40@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcjXU4t4qffyMQQSR5e4ylNJCskyHQPD6JAAACxuKCQ=
Thread-topic: [Xen-devel][PATCH] Fix the boot failure of xenU after destroying aHVM guest
User-agent: Microsoft-Entourage/11.4.0.080122
It's only polite for a subsystem which trashes page_info to reinstate it
when it is done. We'll work out a patch for the p2m code.

 -- Keir

On 16/7/08 01:56, "Xu, Dongxiao" <dongxiao.xu@xxxxxxxxx> wrote:

> Hi, Keir, 
>     I saw in C/S 17899, you put the re-initialize code of the page lock in
> sh_set_allocation() instead of free_heap_pages(). In this condition, I think
> we should also re-initialize the page lock while freeing the shadow p2m page
> and maybe some other places. Because when alloc the shadow p2m page, it will
> use function sh_alloc_p2m_pages()->shadow_alloc() to initialize the page as
> shadow_page_info, so the re-initialize when freeing shadow p2m is necessary.
>     So I think if only put the page lock re-initialize code in
> free_heap_pages(), it is the most safe. And it could fix the bug 1287.
> 
> 1. Sometimes XenU guest cannot boot up on 32e host.
> http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=1287
> 
> Thanks
> -- Dongxiao
> 
> -----Original Message-----
> From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
> [mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Xu, Dongxiao
> Sent: 2008年6月26日 14:12
> To: Keir Fraser; xen-devel@xxxxxxxxxxxxxxxxxxx
> Cc: jbeulich@xxxxxxxxxx
> Subject: [Xen-devel][PATCH] Fix the boot failure of xenU after destroying aHVM
> guest
> 
> Fix the boot failure of xenU after destroying a HVM guest.
> - Both page_info and shadow_page_info are stored in frame_table.
> At first, all spin locks in frame table are initialized as
> SPIN_LOCK_UNLOCKED.
> If one frame is used as shadow_page_info, we still should initialize the
> spin lock to be SPIN_LOCK_UNLOCKED when freeing that page.
> 
> Signed-off-by: Dongxiao Xu <dongxiao.xu@xxxxxxxxx>
> 
> Best Regards,
> -- Dongxiao
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>