WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [qemu-xen]: Fix warnings

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: [Xen-devel] [qemu-xen]: Fix warnings
From: Andre Przywara <andre.przywara@xxxxxxx>
Date: Thu, 10 Jul 2008 17:15:21 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 10 Jul 2008 08:16:36 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 1.5.0.10 (X11/20070409)
Ian,

first thanks for updating qemu/ioemu to a more recent version, that gives a lot of nice features. Below patch fixes two warnings when compiling. If slirp is out of the way, we have only one warning left (monitor.c:69) that prevents us from setting --enable-werror (at least on my setup ;-) This fix is not trivial: - Either refactor the whole monitor code to use other ways of calling the handler functions or
- use casts at every call
Does anyone know of a method preventing gcc to give this particular warning at this particular code line (some kind of pragma?) This would be a much easier solution than the above ones.

Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>

Regards,
Andre.


--
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
Tel: +49 351 277-84917
----to satisfy European Law for business letters:
AMD Saxony Limited Liability Company & Co. KG,
Wilschdorfer Landstr. 101, 01109 Dresden, Germany
Register Court Dresden: HRA 4896, General Partner authorized
to represent: AMD Saxony LLC (Wilmington, Delaware, US)
General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy
diff --git a/hw/scsi-generic.c b/hw/scsi-generic.c
index 60084cf..3973c25 100644
--- a/hw/scsi-generic.c
+++ b/hw/scsi-generic.c
@@ -478,8 +478,8 @@ static int32_t scsi_send_command(SCSIDevice *d, uint32_t 
tag,
                                  uint8_t *cmd, int lun)
 {
     SCSIDeviceState *s = d->state;
-    uint32_t len;
-    int cmdlen;
+    uint32_t len=0;
+    int cmdlen=0;
     SCSIRequest *r;
     int ret;
 
diff --git a/i386-dm/helper2.c b/i386-dm/helper2.c
index 6437c37..d630cb0 100644
--- a/i386-dm/helper2.c
+++ b/i386-dm/helper2.c
@@ -418,7 +418,8 @@ void cpu_ioreq_timeoffset(CPUState *env, ioreq_t *req)
 
     time_offset += (unsigned long)req->data;
 
-    fprintf(logfile, "Time offset set %ld, added offset %lld\n", time_offset, 
req->data);
+    fprintf(logfile, "Time offset set %ld, added offset %"PRId64"\n",
+        time_offset, req->data);
     sprintf(b, "%ld", time_offset);
     xenstore_vm_write(domid, "rtc/timeoffset", b);
 }
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [qemu-xen]: Fix warnings, Andre Przywara <=