WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 1/4] hvm: NUMA guest: extend memops hypercall

To: Andre Przywara <andre.przywara@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH 1/4] hvm: NUMA guest: extend memops hypercall
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Fri, 04 Jul 2008 16:34:18 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 04 Jul 2008 08:34:48 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <486E41B7.8080707@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acjd62wOqqZuekneEd2bbwAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH 1/4] hvm: NUMA guest: extend memops hypercall
User-agent: Microsoft-Entourage/11.4.0.080122
On 4/7/08 16:28, "Andre Przywara" <andre.przywara@xxxxxxx> wrote:

> Have you applied the patches correctly? From 02_numa_guest.patch:
> @@ -115,7 +113,7 @@
>               goto out;
> 
>           page = alloc_domheap_pages(
> -            d, a->extent_order, a->memflags | MEMF_node(node));
> +            d, a->extent_order, a->memflags);
>           if ( unlikely(page == NULL) )
>           {
>               gdprintk(XENLOG_INFO, "Could not allocate order=%d extent:"
> 
> The other use of MEMF_node is in exchange_memory, which is not given any
> NUMA node info from the caller, so this is correct.

When sent a patch sequence I expect the patches to apply and work
independently (when applied one-by-one in order).

Anyway, your second patch changes the default NUMA allocation policy from
allocate on home node for the domain to allocate on node I'm currently
executing on. That would seem a net loss for PV guests (whose builder will
not be explicitly specifying the numa node for allocations).

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel