WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: Re: Re: Re: [Xen-devel] SetPageForeign in netback

To: "Zang Hongyong" <zanghongyong@xxxxxxxxxx>
Subject: Re: Re: Re: Re: [Xen-devel] SetPageForeign in netback
From: "Grzegorz Miłoś" <gm281@xxxxxxxxx>
Date: Tue, 24 Jun 2008 07:41:49 +0100
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 23 Jun 2008 23:42:13 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender :to:subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references :x-google-sender-auth; bh=lARBgsegNE7U0Y1sa7lO6TTXui1+PBZ0WMPhVv8GBqU=; b=W3Vhuus/G/3uN7P9/7Ln3RQ0gX2lhYc14Lc/BL0oxj5LUhLmI4RD8jdEJbNyFOhb+V 2UKtbemiUt+4lUqTfXuq7Ftw7Xf8YN0ipIZjsLudYZ4fZDEMd/LDtM+iedWpq99pcFBD VeHsbi4fiWF1gPC7VfX3BUevipYcuylwUkjiU=
Domainkey-signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references:x-google-sender-auth; b=NUXFH+bpXrmC7vtyevjJ+1FbbEi+UaD/XOeztv9T6dJRnAk3sZKC5CF66Y9JmhM1Zp g8srrxCC18Tdw0v1MUlSlZE5oSg3G2nezr78MOyQh+611UCkM3fmj0gc3ohykuE9Iz6N jLuqvY16IHiaKEEYxAgWhtrZpr9sw76USosEs=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20080624005042.9104C136821@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20080624005042.9104C136821@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>The reason why you have to copy is to make sure that you pull the skb
>>into a fresh page (which doesn't have any other pieces of data in it).
>>It's only then that you can flip it to DomU.
>>It used to be the case that the backend was more efficient in the
>>rx-flip mode. Some/most skbs copies were avoided by keeping a close
>>eye on the skb allocation. Since rx-flip is now only/mostly kept for
>>backward compatibility (rx-copy is the default) the code was
>>simplified.
>
> You mean in previous Xen release, rx-flip is more efficient than today's 
> release. And keeping rx-flip in Xen Source Code tree today is only for 
> compatibility. So no need to do more optimizing for it.
> Is my understanding right?
>

I don't know if much performance was lost (the code got simplified, at
the expense of potentially more skb copies, but I don't know of any
experimental tests to benchmark what the effect was exactly), but
aside from that, your understanding is correct.

Cheers
Gr(z)egor(z)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel