Re: [Xen-devel] [PATCH 0/4] HVM Virtual S3 --- Revised and resent

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 21/5/08 07:31, "Ke, Liping" <liping.ke@xxxxxxxxx> wrote:

> 1. after cpu_reset, seems we need to call vcpu_initialise to reconstruct vmcs,
> otherwise, the domain could not be resumed back and xen has low response then.

I don't like that. We should work out what bit of architectural state needs
to be reset and do that from hvm_vcpu_reset_state().

> 2. yes, we may need to find a way to clear that io_port_write, otherwise, save
> will hang. I add back the clear (defer_shutdown =0) to have a test, then it
> works just fine.

I now agree this is the correct approach, but perhaps we should
vcpu_end_shutdown_deferral() in vcpu_reset().

> 3. in python, seems it will report
>     a. global name "TRIGGER_S3RESUME" is not defined
>     b. global name "HVM_PARAM_ACPI_S_STATE" is not defined

Silly mistakes.

I can help with these a bit. Perhaps I can get myself a test setup today.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel