WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH 0/4] HVM Virtual S3

To: "Ian Pratt" <Ian.Pratt@xxxxxxxxxxxxx>, "Yu, Ke" <ke.yu@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH 0/4] HVM Virtual S3
From: "Ke, Liping" <liping.ke@xxxxxxxxx>
Date: Wed, 14 May 2008 17:50:22 +0800
Cc: "Tian, Kevin" <kevin.tian@xxxxxxxxx>, "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>
Delivery-date: Wed, 14 May 2008 02:52:13 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <DD74FBB8EE28D441903D56487861CD9D2E1E089C@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <391BF3CDD2DC0848B40ACB72FA97AD590352E058@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <DD74FBB8EE28D441903D56487861CD9D2DFDA9B3@xxxxxxxxxxxxxxxxxxxxxx> <391BF3CDD2DC0848B40ACB72FA97AD590352E41A@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <1104166E0B63A341805FDB977862AAD20174A0D1@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <391BF3CDD2DC0848B40ACB72FA97AD5903565F04@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <DD74FBB8EE28D441903D56487861CD9D2E1E089C@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Aciwyj3GC5kFZyVcS9eJk6QW6cxy6gAO58GAAASSNxAAAQ9pEAAnjI9gAAQtZQAA9rPlAA==
Thread-topic: [Xen-devel] [PATCH 0/4] HVM Virtual S3
Hi, Ian and Keir
Thanks for the detailed explanation.
I have tried below solution according to all feedbacks:
1. merged s3suspend+s3resume+domain_pause phase into one s3_suspend phase 
2. s3 resume phase is now very light. Do something like unpause domain
3. add xm trigger <domid> s3resume interface to for s3_resume operation
4. add new state s3suspended plus (paused, blocked, etc)
All works just fine.

Yet I have met below problems:
1. if hvm in s3suspended, could we allow pause/unpause/suspend/resume operation?
    Need we add condition guard in python code?
2. when we add a new flag is_s3_suspended in dominfo structure, it will affect 
other
Trace/statistic tools in xen, seems this is not a very small change? 
   The above two changes is ok for you or not?

Thanks a lot for your help!
Regards,
Criping


Ian Pratt wrote:
>> Today I am trying this idea, I found combining S3
>> sus/resume+domain_pause, and then
>> use domain_unpause letting domain back works fine.
>> 
>> Yet when I am trying xm save after pausing domain, I found if a
>> domain not running, Xm save will reject the save request.
>> So I want to know whether domain running is a must  for xm save
>> operation?
> 
> Yes, you'll certainly need a few tweaks to the save/restore code.
> 
> Normally save/restore needs to send a notification to the guest such
> that the PV drivers get themselves into a 'safe' state. If the guest
> is in S3, the drivers will already be shutdown (hence safe).
> 
> I think you'll need to add an explicit new state that a VM can be in
> (S3 sleep), and then gate out some of the save code based on that
> state. You'll also need to make sure that the state is saved as part
> of the image written to disk to make sure that when it restored it
> remains in S3 sleep until triggered back to life. [We may want to add
> flags to the xm save/restore commands to incorporate S3 sleep and
> wake up behaviour as part of save restore, but this is just CLI
> sugar.] 
> 
> Ian


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel