[Xen-devel] [PATCH] only print pages' mfn-s in dump_pageframe_info()

["Jan Beulich" <jbeulich@xxxxxxxxxx>]

Printing page_to_maddr() and page_to_mfn() of the same page is
redundant, and _p(page_to_maddr(page)) is even incorrect on x86/PAE.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

Index: 2008-05-08/xen/arch/x86/domain.c
===================================================================
--- 2008-05-08.orig/xen/arch/x86/domain.c       2008-05-09 12:05:18.000000000 
+0200
+++ 2008-05-08/xen/arch/x86/domain.c    2008-05-09 12:06:53.000000000 +0200
@@ -138,16 +138,16 @@ void dump_pageframe_info(struct domain *
     {
         list_for_each_entry ( page, &d->page_list, list )
         {
-            printk("    DomPage %p: mfn=%p, caf=%08x, taf=%" PRtype_info "\n",
-                   _p(page_to_maddr(page)), _p(page_to_mfn(page)),
+            printk("    DomPage %p: caf=%08x, taf=%" PRtype_info "\n",
+                   _p(page_to_mfn(page)),
                    page->count_info, page->u.inuse.type_info);
         }
     }
 
     list_for_each_entry ( page, &d->xenpage_list, list )
     {
-        printk("    XenPage %p: mfn=%p, caf=%08x, taf=%" PRtype_info "\n",
-               _p(page_to_maddr(page)), _p(page_to_mfn(page)),
+        printk("    XenPage %p: caf=%08x, taf=%" PRtype_info "\n",
+               _p(page_to_mfn(page)),
                page->count_info, page->u.inuse.type_info);
     }
 }




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel