WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH][SVM] CPL initialization fix

To: Ben Guthro <bguthro@xxxxxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Robert Phillips <rphillips@xxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH][SVM] CPL initialization fix
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Mon, 10 Mar 2008 19:18:26 +0000
Delivery-date: Mon, 10 Mar 2008 12:19:51 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <47D588A8.9030908@xxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AciC44PFwnmBKO7WEdyLvQAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH][SVM] CPL initialization fix
User-agent: Microsoft-Entourage/11.4.0.080122
CPL is architecturally SS.DPL in almost all cases. It's certainly not
CS.DPL. What do you mean by 'migrate a QEMU guest'?

 -- Keir

On 10/3/08 19:14, "Ben Guthro" <bguthro@xxxxxxxxxxxxxxx> wrote:

> CPL should be determined by code segment's DPL, not data segment's.
> 
> This solves a problem migrating a QEMU guest without PV-on-HVM drivers
> 
> Signed-off-by: Robert Plillips <rphillips@xxxxxxxxxxxxxxx>
> Signed-off-by: Ben Guthro <bguthro@xxxxxxxxxxxxxxxx>
> diff -r f76f151a7431 xen/arch/x86/hvm/svm/svm.c
> --- a/xen/arch/x86/hvm/svm/svm.c
> +++ b/xen/arch/x86/hvm/svm/svm.c
> @@ -557,7 +557,7 @@ static void svm_set_segment_register(str
>          break;
>      case x86_seg_ss:
>          memcpy(&vmcb->ss, reg, sizeof(*reg));
> -        vmcb->cpl = vmcb->ss.attr.fields.dpl;
> +        vmcb->cpl = vmcb->cs.attr.fields.dpl;
>          break;
>      case x86_seg_tr:
>          memcpy(&vmcb->tr, reg, sizeof(*reg));
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel