WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH][retry 3][1/2] new vcpu op call to get physicalCP

To: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH][retry 3][1/2] new vcpu op call to get physicalCPU information
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Wed, 5 Mar 2008 11:40:00 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Mark Langsdorf <mark.langsdorf@xxxxxxx>
Delivery-date: Wed, 05 Mar 2008 03:41:16 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <47CE6491.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <200803041552.28425.mark.langsdorf@xxxxxxx> <47CE6491.76E4.0078.0@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Jan Beulich writes ("Re: [Xen-devel] [PATCH][retry 3][1/2] new vcpu op call to 
get physicalCPU information"):
> >+    short temp = 0xff;
...
> >+    cpu_id.phys_id |= temp << 8;
> 
> Please shift by 32 here for forward compatibility.

short promotes to int, probably 32-bit, but shifting by the word size
or more is not permitted.  In any case even if it worked like you
wanted, the result would be 0.  Perhaps you meant to suggest some
changes of types as well ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel